search

macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.
https://macosui.github.io/macos_ui/#/
MIT License
1.83k stars 177 forks source link

Drag scrolling is disabled after upgrading to Flutter 2.5 #154

Closed vumanhsn97 closed 3 years ago

vumanhsn97 commented 3 years ago

Description

Create new scroll behavior to migrate flutter 2.5 https://flutter.dev/docs/release/breaking-changes/default-scroll-behavior-drag

MacosApp widget does not apply new custom scroll behavior MacosApp( scrollBehavior: MyCustomScrollBehavior(),

GroovinChip commented 3 years ago

@vumanhsn97 do you have a gif or something that you can provide that demonstrates the bug?

GroovinChip commented 3 years ago

Upon cursory inspection it appears that our MacosScrollBehavior is not overriding the new dragDevices getter. This should be trivial to update, but I would still like to see a gif of the bug before I do please.

vumanhsn97 commented 3 years ago

When you upgrade to flutter 2.5, MacosApp can't able using mouse to scroll a listview. It is only working with scroll wheel https://streamable.com/6prtrc

Everything is working well with flutter 2.2

GroovinChip commented 3 years ago

Thank you for providing more detail. This does indeed seem to me to be related to overriding the new dragDetails getter in Flutter 2.5. However, I'm not convinced that drag scrolling should be allowed with macos_ui, given that it is a desktop framework. I will give it some thought.

GroovinChip commented 3 years ago

https://twitter.com/groovinchip/status/1437422926580572160?s=21

GroovinChip commented 3 years ago

@vumanhsn97 I will not be implementing drag scrolling for macos_ui. If you require it, please feel free to fork the package and add it via the MacosScrollBehavior class.