Full screen opaque toolbar issue (closes #249)

whiplashoo commented 2 years ago

Fixes #249 by editing the app window's implementation in Swift. Now when the app goes in full screen, no toolbar is shown at all. When it returns from full screen, the toolbar is again "visible", to make the close/minimize/maximize buttons have the proper alignment.

https://user-images.githubusercontent.com/9117427/168389835-70cd2318-26f3-4172-835d-fba234857333.mp4

The docs have also been updated.

Pre-launch Checklist

[👍 ] I have run dartfmt on all changed files
[ 👍 ] I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
[👍 ] I have added/updated relevant documentation
[👍 ] I have run "optimize/organize imports" on all changed files
[👍 ] I have addressed all analyzer warnings as best I could

GroovinChip commented 2 years ago

I'm a little confused about the language you're using to describe what's happening here. As far as I can tell, the Toolbar widget remains visible in fullscreen. Are you referring to native titlebar?

whiplashoo commented 2 years ago

Yes, I am referring to the native element which we build here (to have the proper alignment for the minimize/maximize/close buttons). Our ToolBar widget remains now visible as intended, yes.

GroovinChip commented 2 years ago

Okay, understood. Thanks for the clarification.

GroovinChip commented 2 years ago

Actually hang on, why are the checks failing? I'm on mobile.

macosui / macos_ui

Full screen opaque toolbar issue (closes #249) #252

Pre-launch Checklist