search

macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.
https://macosui.github.io/macos_ui/#/
MIT License
1.86k stars 183 forks source link

Build error on Flutter beta due to TapUpDetails #361

Closed cbenhagen closed 1 year ago

cbenhagen commented 1 year ago

Description _TextFieldSelectionGestureDetectorBuilderonSingleTapUp' has type 'TapUpDetails', which does not match the corresponding type, 'TapDragUpDetails',

Flutter (Channel beta, 3.8.0-10.1.pre, on macOS 13.2.1 22D68 darwin-arm64, locale en-US)

Logs

Logs ``` ../../../.pub-cache/hosted/pub.dev/macos_ui-1.10.0/lib/src/fields/text_field.dart:108:35: Error: The parameter 'details' of the method '_TextFieldSelectionGestureDetectorBuilder.onSingleTapUp' has type 'TapUpDetails', which does not match the corresponding type, 'TapDragUpDetails', in the overridden method, 'TextSelectionGestureDetectorBuilder.onSingleTapUp'. - 'TapUpDetails' is from 'package:flutter/src/gestures/tap.dart' ('../../flutter/packages/flutter/lib/src/gestures/tap.dart'). - 'TapDragUpDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart'). Change to a supertype of 'TapDragUpDetails', or, for a covariant parameter, a subtype. void onSingleTapUp(TapUpDetails details) { ^ ../../flutter/packages/flutter/lib/src/widgets/text_selection.dart:2144:8: Context: This is the overridden method ('onSingleTapUp'). void onSingleTapUp(TapDragUpDetails details) { ^ ../../../.pub-cache/hosted/pub.dev/macos_ui-1.10.0/lib/src/fields/text_field.dart:130:42: Error: The parameter 'details' of the method '_TextFieldSelectionGestureDetectorBuilder.onDragSelectionEnd' has type 'DragEndDetails', which does not match the corresponding type, 'TapDragEndDetails', in the overridden method, 'TextSelectionGestureDetectorBuilder.onDragSelectionEnd'. - 'DragEndDetails' is from 'package:flutter/src/gestures/drag_details.dart' ('../../flutter/packages/flutter/lib/src/gestures/drag_details.dart'). - 'TapDragEndDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart'). Change to a supertype of 'TapDragEndDetails', or, for a covariant parameter, a subtype. void onDragSelectionEnd(DragEndDetails details) { ^ ../../flutter/packages/flutter/lib/src/widgets/text_selection.dart:2688:8: Context: This is the overridden method ('onDragSelectionEnd'). void onDragSelectionEnd(TapDragEndDetails details) { ^ ``` ``` ``` ``` ```
GroovinChip commented 1 year ago

This is because macos_ui is developed against the stable channel. Eventually the changes causing this issue will come to stable and macos_ui will account for them once they do.

cbenhagen commented 1 year ago

@GroovinChip can I convince you to reconsider this? Maybe there is a solution which works for both? I am ok with this plugin not always working with the latest master. But it would be very nice if we could try to make it work for beta and stable at least.

cbenhagen commented 1 year ago

At the very least I think this issue should be kept open as at some point this needs to be fixed.

GroovinChip commented 1 year ago

It isn't a problem currently. As such there is no need for it to be open and it will remain closed.

I did open #362 to further clear up which branch users should be on.

GroovinChip commented 1 year ago

Your other option is to depend on the customer_testing branch of macos_ui, which is based on the master channel. This branch exists so that if anything changes in Flutter that breaks our tests, we'll know and can address it.

mariopepe commented 1 year ago

@cbenhagen here we go 🤣🤣🤣🤣