123669 handle invalid dates

macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.

https://macosui.github.io/macos_ui/#/

MIT License

1.81k stars 178 forks source link

123669 handle invalid dates #401

Closed eliasyishak closed 1 year ago

eliasyishak commented 1 year ago

Refers to issue: https://github.com/flutter/flutter/issues/123669

My detailed explanation is in this comment: https://github.com/flutter/flutter/issues/123669#issuecomment-1488908243

Pre-launch Checklist

[x] I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
[x] I have added/updated relevant documentation
[x] I have run "optimize/organize imports" on all changed files
[x] I have addressed all analyzer warnings as best I could

eliasyishak commented 1 year ago

@GroovinChip let me know if I did this correctly for the PR. I was not sure if I should be merging into dev or customer_testing.

Also for the fix, it was even simpler to just set the _selectedDay variable to be 1 so it always points to the beginning of the month. Let me know if this is an okay assumption to make.

GroovinChip commented 1 year ago

@eliasyishak Thanks for submitting this fix. You're correct to target the dev branch. I'll review this now.

eliasyishak commented 1 year ago

@eliasyishak Thanks for submitting this fix. You're correct to target the dev branch. I'll review this now.

Oh but it seems like I targeted customer_testing, should I point it to dev instead?

GroovinChip commented 1 year ago

@eliasyishak Thanks for submitting this fix. You're correct to target the dev branch. I'll review this now.

Oh but it seems like I targeted customer_testing, should I point it to dev instead?

Ah yes. Please target dev.

GroovinChip commented 1 year ago

@eliasyishak Which Flutter channel are you on? see https://github.com/macosui/macos_ui/blob/dev/CONTRIBUTING.md#branch-structure

eliasyishak commented 1 year ago

Is it better for me to make the change on a fork of dev instead? I was getting a lot of errors when I forked dev in the tests initially so i used customer_testing instead.

GroovinChip commented 1 year ago

Yes, as explained in CONTRIBUTING.md, macos_ui is developed on Flutter's stable channel. Only the customer_testing branch is on master. You likely experienced those errors because you are not on Flutter's stable channel.

eliasyishak commented 1 year ago

Closing to move to another PR based on dev