macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.
https://macosui.github.io/macos_ui/#/
MIT License
1.88k stars 183 forks source link

feat: Added support for `startWeekOnMonday` to `MacosDatePicker` #414

Closed rklos closed 1 year ago

rklos commented 1 year ago

This is the first step in fulfilling all requests from https://github.com/macosui/macos_ui/issues/369. I've added an optional parameter startWeekOnMonday which allows to render a calendar with Monday as a first day of the week.

This is a temporary solution, because the need of this feature is caused by invalid implementation of firstDayOfWeekIndex in flutter_localizations package: https://github.com/flutter/flutter/issues/122274

Pre-launch Checklist

rklos commented 1 year ago

I've added an additional test that checks if startWeekOnMonday is still necessary. This test will fail on customer_testing branch when Flutter has fixed firstDayOfWeekIndex.

rklos commented 1 year ago

Done @GroovinChip

GroovinChip commented 1 year ago

LGTM. Waiting on checks.