Non-scrollable `ResizablePane`

macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.

https://macosui.github.io/macos_ui/#/

MIT License

1.81k stars 178 forks source link

Non-scrollable `ResizablePane` #420

Closed stMerlHin closed 1 year ago

stMerlHin commented 1 year ago

This PR add new constructor RezizablePane.noScrollBar to ResizablePane class. It allow user to disable the internal MacosScrollbar witch is in by default in the ResizablePaneWidget

close #413

Pre-launch Checklist

[x] I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
[x] I have added/updated relevant documentation
[x] I have run "optimize/organize imports" on all changed files
[x] I have addressed all analyzer warnings as best I could

GroovinChip commented 1 year ago

@stMerlHin this is one of the last issues in play before a stable 2.0 can be released. Do you mind wrapping this up, please?

GroovinChip commented 1 year ago

I'm taking this off the 2.0 milestone.

stMerlHin commented 1 year ago

Hey @GroovinChip, hope you're fine. I'm really sorry that I didn't give any sign of life. I was a little busy. I will update this PR ASAP.

stMerlHin commented 1 year ago

I actually don't know how to resolve this. It's from dart code metrics check.

GroovinChip commented 1 year ago

I actually don't know how to resolve this. It's from dart code metrics check.

don't worry about this, I'll deal with it

GroovinChip commented 1 year ago

Hey @GroovinChip, hope you're fine. I'm really sorry that I didn't give any sign of life. I was a little busy. I will update this PR ASAP.

No worries mate, I know how it is :)

GroovinChip commented 1 year ago

@stMerlHin the DCM action is failing because your PR is from a fork, we can just ignore this check.

stMerlHin commented 1 year ago

@stMerlHin Looks good but I think you need to run pub get, I don't see updated lock files

Will do so.