search

macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.
https://macosui.github.io/macos_ui/#/
MIT License
1.81k stars 178 forks source link

Allow custom CupertinoThemeData, and some flexibility of Alerts. #433

Closed mattsrobot closed 1 year ago

mattsrobot commented 1 year ago

Dear macOS-ui team,

I needed to be able to toggle darkmode and light mode, which meant propagating the CupertinoThemeData.

I've also allowed some more flexibility in the alerts.

Attached, video in action!

https://github.com/macosui/macos_ui/assets/19474610/aa699488-076d-4013-b6a2-bdcce4059bd2

GroovinChip commented 1 year ago

Hello @mattsrobot, and thanks for the PR.

Toggling between light and dark themes is already supported. Please check out our gallery app which demonstrates one possible approach you can take to do this. As such, this change is not necessary.

Additionally, this library aims to rely on material and cupertino as little as possible. For this reason, your change is undesired.

I do sincerely appreciate your willingness to contribute, so please don't be discouraged from doing so again in the future :)

Cheers!