Enhancement - new hasActiveSelection property for SidebarItems

macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.

https://macosui.github.io/macos_ui/#/

MIT License

1.79k stars 174 forks source link

Enhancement - new hasActiveSelection property for SidebarItems #465

Closed ganeshrvel closed 9 months ago

ganeshrvel commented 12 months ago

🔄 Updated 🔄

SidebarItems now accepts hasActiveSelection property which indicates whether any of the items in the sidebar has been selected.

Pre-launch Checklist

[x] I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
[x] I have added/updated relevant documentation
[x] I have run "optimize/organize imports" on all changed files
[x] I have addressed all analyzer warnings as best I could

GroovinChip commented 12 months ago

Hi @ganeshrvel, please post a screenshot of your change

ganeshrvel commented 12 months ago

Screen recording of the changes:

https://github.com/macosui/macos_ui/assets/182092/49e8d1cd-ad28-414b-b63f-f330265c7fd2

GroovinChip commented 12 months ago

Thanks for the recording. What's the purpose of this change?

ganeshrvel commented 12 months ago

Thanks for the recording. What's the purpose of this change?

Currently, the SidebarItems are built with the presumption that any selection within the content area should occur as a result of an action on one of the SidebarItems.

However, a sidebar could contain multiple items, including multiple SidebarItems, Texts, Buttons, etc., and the displayed contents may not necessarily be directly related to the items on the Sidebar.

For example, consider the File explorer sidebar on macOS or Windows. Users may navigate between files, and only when they open a pinned item on the side, it should be highlighted.

ganeshrvel commented 11 months ago

@GroovinChip bumping this reply as a reminder

GroovinChip commented 11 months ago

@GroovinChip bumping this reply as a reminder

Little busy, mate. I'll get to it.

GroovinChip commented 11 months ago

@ganeshrvel so the thing is, we need to implement #271 and I'm reluctant to accept any changes related to the sidebar until we do. Do you think your change might collide with such work? Or would you perhaps be willing to take #271 on and fold this change into it, if it's even still needed at that point?

GroovinChip commented 9 months ago

I am closing this due to inactivity.