macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.
https://macosui.github.io/macos_ui/#/
MIT License
1.79k stars 174 forks source link

Alter copy of mock_canvas to unblock moving to flutter_test #467

Closed Piinks closed 11 months ago

Piinks commented 11 months ago

Came up as a test failure in https://github.com/flutter/flutter/pull/131631

Since mock_canvas was copied into this repo, the analysis will fail when we try to make it public. This just renames the methods so we can land the change. Once it is part of flutter_test, the copy of recording_canvas and mock_canvas can be removed entirely since it will be public.

The commit in flutter/tests will need to be updated after this for the PR in flutter/flutter to be able to land.

Pre-launch Checklist

Piinks commented 11 months ago

@GroovinChip

GroovinChip commented 11 months ago

Amazing! Thank you, Kate!