Allow custom sizes in SidebarItemsConfiguration

macosui / macos_ui

Flutter widgets and themes implementing the current macOS design language.

https://macosui.github.io/macos_ui/#/

MIT License

1.88k stars 183 forks source link

Allow custom sizes in SidebarItemsConfiguration #476

Open plarson opened 1 year ago

plarson commented 1 year ago

First PR for this repository. I needed to make the sidebar icons bigger so I reconfigured SidebarItemsConfiguration to not be private.

Pre-launch Checklist

[ ] I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
[X] I have added/updated relevant documentation
[X] I have run "optimize/organize imports" on all changed files
[X] I have addressed all analyzer warnings as best I could

GroovinChip commented 1 year ago

Hi @plarson and thank you for your first PR to this project.

I am not certain that making SidebarItemsConfiguration is the best technical choice to achieve the desired result. I'd lean towards adding an iconSize property to the Sidebar itself.

That said, it is not clear to me if Apple has a design opinion about this. The Human Interface Guidelines make no mention of it, and research is required to see if SwiftUI supports it. I will look into this and get back to you.

GroovinChip commented 2 months ago

@plarson I have the answer: https://developer.apple.com/design/human-interface-guidelines/sidebars#macOS

Please look through this and update your PR to match the specs outlined here. Thanks!