search

macports / macports-webapp

Web application to display information about ports, build history and installation statistics
https://ports.macports.org/
BSD 2-Clause "Simplified" License
53 stars 25 forks source link

known_fail should not be seen as a build success #344

Open kencu opened 2 years ago

kencu commented 2 years ago

when a port sets known_fail on a system version, it should be displayed as a fail in the webapp, not a success

mascguy commented 2 years ago

I'd prefer that we have a 3rd status - like "not supported," or something akin to that - to differentiate from a simple success/failure.

Anyone else... thoughts?

kencu commented 2 years ago

Anything but success

jmroot commented 2 years ago

AFAIK, you currently see the grey question mark for known_fail ports, since no build takes place. An indicator that it is known to fail rather than just not built would be nice.

Of course if there was a successful build of a previous version, #135 will be in effect.

mascguy commented 2 years ago

Similarly, if there was at least one build failure prior to setting known_fail, that will also be in effect.

And that can be a bit frustrating, when drilling down the dependency tree.

ryandesign commented 1 year ago

AFAIK, you currently see the grey question mark for known_fail ports, since no build takes place. An indicator that it is known to fail rather than just not built would be nice.

Only if no build of that port (any version) has ever taken place on that builder. If a build has taken place in the past, then that information is displayed by the web app even if it is outdated. Ideally the web app would not display outdated information.

jmroot commented 1 year ago

Yes, hence the reference to #135.