search

macports / upt-macports

The Universal Packaging Tool (upt) backend for MacPorts
https://framagit.org/upt/upt
BSD 3-Clause "New" or "Revised" License
9 stars 12 forks source link

Not scanning for frontend when creating output dir #47

Closed Korusuke closed 5 years ago

Korusuke commented 5 years ago

Fixes #41

codecov[bot] commented 5 years ago

Codecov Report

Merging #47 into master will decrease coverage by 0.17%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage    85.8%   85.62%   -0.18%     
==========================================
  Files           1        1              
  Lines         162      160       -2     
  Branches        7        7              
==========================================
- Hits          139      137       -2     
  Misses         23       23
Impacted Files Coverage Δ
upt_macports/upt_macports.py 85.62% <100%> (-0.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ce0be7...32effa0. Read the comment docs.

Korusuke commented 5 years ago

I don't think there might be anything wrong in this PR as this was previously disscussed. So we can merge this first and then rebase and merge #35

reneeotten commented 5 years ago

this looks fine to me. Since @Steap opened the issue about this I'll let him take another look and, if he agrees, merge this PR!

Steap commented 5 years ago

Done :)