Steap commented 4 years ago

Tests: bump the target coverage percentage. Remove NPM implementation. Use a single _pkgname method for all package types. Add tests for the jinja2_reqformat methods.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7eb75a1). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage          ?   90.64%           
=========================================
  Files             ?        1           
  Lines             ?      171           
  Branches          ?       10           
=========================================
  Hits              ?      155           
  Misses            ?       16           
  Partials          ?        0

Impacted Files	Coverage Δ
upt_macports/upt_macports.py	`90.64% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7eb75a1...6580061. Read the comment docs.

Steap commented 4 years ago

Can't remember what our merge policy was, two approvals means I can press that big green button? :)

mojca commented 4 years ago

No particular merge policy. It depends on how confident you are in your changes and whether you want to get an approval from someone else.

In the main ports tree we try to respect 72-hour window for the official maintainer to respond, but this is basically the work between @Korusuke , you and @reneeotten, so whatever you feel makes sense can be used here ...

Korusuke commented 4 years ago

thanks @Steap

macports / upt-macports

Pull request for tests #56

Codecov Report