reneeotten commented 4 years ago

This PR makes the changes below to the license logging and templates:

"no license found" should be logged as warning, not as info
add the reasons (i.e., "no upstream license found" and "upt failed to detect the license") to the template as helpful information for the maintainer to figure out why the license field was set to "uknown" by upt
use two spaces for inline comments

codecov[bot] commented 4 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   90.62%   90.67%   +0.04%     
==========================================
  Files           1        1              
  Lines         192      193       +1     
  Branches       15       15              
==========================================
+ Hits          174      175       +1     
  Misses         16       16              
  Partials        2        2

Impacted Files	Coverage Δ
upt_macports/upt_macports.py	`90.67% <100%> (+0.04%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32773a5...ce0f069. Read the comment docs.

Steap commented 4 years ago

It is nice to have more precise error/warning messages, as it will help us debug issues. I second this change.

macports / upt-macports

Fix license logging and add messages to the template #61

Codecov Report