macrojd / tag-summary

58 stars 8 forks source link

Handle long list items, complete with settings #12

Closed shaunabanana closed 1 year ago

shaunabanana commented 1 year ago

Thank you for the very useful plugin!

This pull request addresses #9 . Originally, a long list is treated as a single paragraph, as there are usually no empty lines between list items.

To solve this problem, I've added code to iterate through the lines and pick out list items by checking for the starting "- ". The items are again checked for tags the same way paragraphs are checked, and only added to the summary if it passes the test. I've also added an option to include the child items.

Two new settings ("List Items As Paragraphs" and "Include Child List Items") are also added. With the two settings disabled, the plugin functions the same as before.

macrojd commented 1 year ago

Thanks for the help. I had to modify your code because I needed to include multiple levels and also multiple types of lists (numbered and bullets), but the new version is already available. It is the 2.0.0. Thanks again for the contribution and if you try it, let me know whether it works as expected or not.

shaunabanana commented 1 year ago

Hi @macrojd , thank you again for your work! I just tried the new version, but the support for multiple levels seems to not function as expected. Specifically, list items from the second level onward is not showing up. I have tested with this snippet:

- Text at first level indentation with tag (works) #Test
- Text at first level indentation
    - Text at second level indentation (does not work) #Test 

And only the first item is shown. Any thoughts?

macrojd commented 1 year ago

You are right. I didn't think that this would be necessary and only programmed the plugin to read the tags on the parent item, not the children. I'll fix it as soon as possible.