Add logging to cleanup method and use profile.activated

macropin / django-registration

Django-registration (redux) provides user registration functionality for Django websites.

http://django-registration-redux.readthedocs.org

Other

974 stars 350 forks source link

Add logging to cleanup method and use profile.activated #308

Closed joshblum closed 6 years ago

joshblum commented 6 years ago

Addresses #233. @felixSchl sorry this so long to get around to. let me know if this addresses your issue! @dicato wasn't sure what you had in mind for beefing up the unit tests but if you have any suggestions happy to throw them in

coveralls commented 6 years ago

Coverage decreased (-0.07%) to 97.248% when pulling 6fbde192cdf3700a1a2af3c97663fb0d6a317afa on fix-cleanup-task into ddbfbfa57e7ea47c3b3368c0e1fd40752b37fd9a on master.

coveralls commented 6 years ago

Coverage decreased (-0.07%) to 97.248% when pulling 6fbde192cdf3700a1a2af3c97663fb0d6a317afa on fix-cleanup-task into ddbfbfa57e7ea47c3b3368c0e1fd40752b37fd9a on master.

dicato commented 6 years ago

@joshblum regarding the tests, if I remember correctly you have three attributes you are performing logic on:

whether the profile is activated
whether the user is active
and, to some extent, whether the user exists

The unit tests did not cover all these situations.

joshblum commented 6 years ago

Awesome, added a test for an active and expired user. Let me know your opinion on adding a logging config to the docs or some other approach!

coveralls commented 6 years ago

Coverage decreased (-0.4%) to 96.97% when pulling 99cf61bd0765629a48dc28011ba7e7bd77cb701c on fix-cleanup-task into 669f70d3d3283f147b0bddc884b6a5754f866e73 on master.

coveralls commented 6 years ago

Coverage decreased (-0.05%) to 97.306% when pulling 99cf61bd0765629a48dc28011ba7e7bd77cb701c on fix-cleanup-task into 669f70d3d3283f147b0bddc884b6a5754f866e73 on master.

coveralls commented 6 years ago

Coverage decreased (-0.05%) to 97.306% when pulling 99cf61bd0765629a48dc28011ba7e7bd77cb701c on fix-cleanup-task into 669f70d3d3283f147b0bddc884b6a5754f866e73 on master.

coveralls commented 6 years ago

Coverage decreased (-0.05%) to 97.333% when pulling 0f81c6b94a056e09aace52a69b93ee1ba0a8d590 on fix-cleanup-task into 32013cee562f308feaabd8fc2b0f83b36bd3e09f on master.