search

macropin / django-registration

Django-registration (redux) provides user registration functionality for Django websites.
http://django-registration-redux.readthedocs.org
Other
974 stars 350 forks source link

reverse_lazy() should take a view function name as input instead of a string #316

Closed zhuyuecai closed 6 years ago

zhuyuecai commented 6 years ago

since in urls.py, all reverse_lazy() for the success url are passed by a string(the url name), it raise no page found when for example I reset my password before log in. it should redirect to a the url ^accounts/ ^password/reset/done/$ [name='auth_password_reset_done'] however, the url actually redirecting is : /accounts/password/change/auth_password_change_done

should change reverse_lazy() to redirect() with the same input?

joshblum commented 6 years ago

@zhuyuecai I'm not sure I follow. Right now resetting your password has a success url of auth_password_reset_done and changing your password has a success url of auth_password_change_done.

zhuyuecai commented 6 years ago

Sorry, I make a mistake, I bug is in another django-registration, not this one, I will close the issue, I didn't know there is two django-registration .

joshblum commented 6 years ago

No problem! On Mon, Jan 15, 2018 at 12:17 Victor notifications@github.com wrote:

Sorry, I make a mistake, I bug is in another django-registration, not this one, I will close the issue, I didn't know there is two django-registration .

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/macropin/django-registration/issues/316#issuecomment-357743374, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF01L09NFFGA-BIg3abChr6SIKB_qDgks5tK4hDgaJpZM4RdVoR .