Changed path reference from 'login' to 'auth_login

[roderik333]

This caused a trace-back when using the default templates.

[coveralls]

Coverage remained the same at 97.068% when pulling 957a8073b10e5965224390317de13f851dae9072 on roderik333:admin-approve-auth-login into d0b4cce3f5f0e29a837e92fc86cc6866085b2668 on macropin:master.

[joshblum]

hey @roderik333 i wasn't able to reproduce the error using the test_app -- can you add the traceback here?

[pencerw]

@joshblum @roderick333 I have the same issue, and changing the references to auth_login fixes it for me. full traceback here:

Environment:

Request Method: GET
Request URL: https://dongxistaging.theprepared.org/accounts/approve/7/

Django Version: 2.1.11
Python Version: 3.7.3
Installed Applications:
['registration',
 'django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'supplychain.apps.SupplychainConfig',
 'supplychain.templatetags',
 'django.contrib.flatpages',
 'django.contrib.sites',
 'bootstrap4',
 'rest_framework',
 'rest_framework_datatables',
 'chartjs',
 'wagtail.contrib.forms',
 'wagtail.contrib.redirects',
 'wagtail.embeds',
 'wagtail.sites',
 'wagtail.users',
 'wagtail.snippets',
 'wagtail.documents',
 'wagtail.images',
 'wagtail.search',
 'wagtail.admin',
 'wagtail.core',
 'modelcluster',
 'taggit',
 'blog',
 'users',
 'crispy_forms',
 'bootstrap_modal_forms',
 'widget_tweaks']
Installed Middleware:
('whitenoise.middleware.WhiteNoiseMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'whitenoise.middleware.WhiteNoiseMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.contrib.flatpages.middleware.FlatpageFallbackMiddleware',
 'wagtail.core.middleware.SiteMiddleware',
 'wagtail.contrib.redirects.middleware.RedirectMiddleware')

Template error:
In template /app/dongxi/templates/registration/admin_approve_complete_email.txt, error at line 5
   Reverse for 'login' not found. 'login' is not a valid view function or pattern name.
   1 : {% load i18n %}
   2 : {% blocktrans %}
   3 : Your account is now approved. You can log in using the following link
   4 : {% endblocktrans %}
   5 : http://{{site.domain}} {% url 'login' %} 
   6 : 
   7 : {% comment %}
   8 : **registration/admin_approve_complete_email.txt**
   9 : 
   10 : Used after successful account activation. This template has no context
   11 : variables of its own, and should simply inform the user that their
   12 : account is now active.
   13 : {% endcomment %}
   14 : 

Traceback:

File "/app/.heroku/python/lib/python3.7/site-packages/django/core/handlers/exception.py" in inner
  34.             response = get_response(request)

File "/app/.heroku/python/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  126.                 response = self.process_exception_by_middleware(e, request)

File "/app/.heroku/python/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  124.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/app/.heroku/python/lib/python3.7/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
  21.                 return view_func(request, *args, **kwargs)

File "/app/.heroku/python/lib/python3.7/site-packages/django/views/generic/base.py" in view
  68.             return self.dispatch(request, *args, **kwargs)

File "/app/.heroku/python/lib/python3.7/site-packages/django/views/generic/base.py" in dispatch
  88.         return handler(request, *args, **kwargs)

File "/app/.heroku/python/lib/python3.7/site-packages/registration/views.py" in get
  159.         approved_user = self.approve(*args, **kwargs)

File "/app/.heroku/python/lib/python3.7/site-packages/registration/backends/admin_approval/views.py" in approve
  62.                 user_id, get_current_site(self.request)))

File "/app/.heroku/python/lib/python3.7/site-packages/registration/models.py" in admin_approve_user
  534.             profile.send_admin_approve_complete_email(site, request)

File "/app/.heroku/python/lib/python3.7/site-packages/registration/models.py" in send_admin_approve_complete_email
  704.             admin_approve_complete_email_html

File "/app/.heroku/python/lib/python3.7/site-packages/registration/models.py" in send_email
  68.                                    ctx_dict)

File "/app/.heroku/python/lib/python3.7/site-packages/django/template/loader.py" in render_to_string
  62.     return template.render(context, request)

File "/app/.heroku/python/lib/python3.7/site-packages/django/template/backends/django.py" in render
  61.             return self.template.render(context)

File "/app/.heroku/python/lib/python3.7/site-packages/django/template/base.py" in render
  171.                     return self._render(context)

File "/app/.heroku/python/lib/python3.7/site-packages/django/template/base.py" in _render
  163.         return self.nodelist.render(context)

File "/app/.heroku/python/lib/python3.7/site-packages/django/template/base.py" in render
  937.                 bit = node.render_annotated(context)

File "/app/.heroku/python/lib/python3.7/site-packages/django/template/base.py" in render_annotated
  904.             return self.render(context)

File "/app/.heroku/python/lib/python3.7/site-packages/django/template/defaulttags.py" in render
  442.             url = reverse(view_name, args=args, kwargs=kwargs, current_app=current_app)

File "/app/.heroku/python/lib/python3.7/site-packages/django/urls/base.py" in reverse
  90.     return iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs))

File "/app/.heroku/python/lib/python3.7/site-packages/django/urls/resolvers.py" in _reverse_with_prefix
  622.         raise NoReverseMatch(msg)

Exception Type: NoReverseMatch at /accounts/approve/7/
Exception Value: Reverse for 'login' not found. 'login' is not a valid view function or pattern name.