search

macropin / django-registration

Django-registration (redux) provides user registration functionality for Django websites.
http://django-registration-redux.readthedocs.org
Other
974 stars 348 forks source link

Replace Deprecated Dependency in Support of Django 3.0 #372

Closed clarkmoody closed 4 years ago

clarkmoody commented 4 years ago

Fixes #371

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.6%) to 96.662% when pulling 475857dbca38bcdc169be6ed4860221cad85fd0e on perceptiveminds:master into 012dbc6de505ed862b66ee507af20b654a8ee4b1 on macropin:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.6%) to 96.664% when pulling 9f85c310a9a05db6e79bba557c3995c43946ae71 on perceptiveminds:master into 012dbc6de505ed862b66ee507af20b654a8ee4b1 on macropin:master.

perceptiveminds commented 4 years ago

In Django 3, the UserCreationForm contains the error message

The two password fields didn’t match

(with a non-ASCII ’ character)

To check for that message, the ’ character needs to be in tests/forms.py. But then tox / lint fails with a non-ASCII error for Python 2, even when using # coding = utf-8.

Do you know a way to fix the code to pass that test for Python 2? (It should not matter at all, since Django 3 doesn't even run on Python 2)

macropin commented 4 years ago

I don't think this is the approach we should take. I'm thinking conditional import and a noop on the decorator if not required.

joshblum commented 4 years ago

closing in favor of https://github.com/macropin/django-registration/pull/373