search

macropin / django-registration

Django-registration (redux) provides user registration functionality for Django websites.
http://django-registration-redux.readthedocs.org
Other
974 stars 348 forks source link

Moved python_2_unicode_compatible dependency from Django to SIX #377

Closed adlerosn closed 4 years ago

adlerosn commented 4 years ago

Django 3.0 removed python_2_unicode_compatible from django.utils.encoding. This causes this django app to break.

What Django did in version 2.2 was just forwarding the same function defined in six package. So, if you replace django.utils.encoding by six on models.py#L21, it'll fix the issue.

You might want to bump the version after accepting this pull request.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.08%) to 97.171% when pulling c814a64b21595db32d088d3b64bdd26aaaacd9e6 on adlerosn:django3fix into 012dbc6de505ed862b66ee507af20b654a8ee4b1 on macropin:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.08%) to 97.171% when pulling 5697571d5750d13f586e2291c2c1bd80322438f4 on adlerosn:django3fix into 012dbc6de505ed862b66ee507af20b654a8ee4b1 on macropin:master.

joshblum commented 4 years ago

closing in favor of https://github.com/macropin/django-registration/pull/373