macropin / django-registration

Django-registration (redux) provides user registration functionality for Django websites.
http://django-registration-redux.readthedocs.org
Other
974 stars 348 forks source link

Dropped Django 1.11 and Python 2.7 support, and fixed deprecation warnings for Django 3.1. #398

Closed felixxm closed 3 years ago

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.2%) to 97.052% when pulling 0d7e289fe4890826d680b03145178d4670d908f1 on felixxm:django31-url-path into b66ddb4b0044c5a0f24b6a23d5387f68b6d7e577 on macropin:master.

macropin commented 3 years ago

Thanks for this.

My only concern is the extra indent space on wrapped lines. Is there a reason for this? (We should probably have a linter to ensure consistent formatting)

felixxm commented 3 years ago

My only concern is the extra indent space on wrapped lines. Is there a reason for this? (We should probably have a linter to ensure consistent formatting)

I added them because they were reported by make lint (used by TravisCI) :shrug:

joshblum commented 3 years ago

@felixxm looks good overall, thanks! Curious why you chose to drop the regular expressions and used path(...) instead of re_path(...)

felixxm commented 3 years ago

path() is more readable and simpler, IMO, that's why we add it to Django, to avoid regular expression where they're not necessary (see release notes).

felixxm commented 3 years ago

I can prepare later follow up PRs with removing Python 2 shims.

joshblum commented 3 years ago

I can prepare later follow up PRs with removing Python 2 shims. Sounds great! I'll prepare a release once that is in

felixxm commented 3 years ago

PR with the most obvious changes is ready, #399.