Closed felixxm closed 3 years ago
Thanks for this.
My only concern is the extra indent space on wrapped lines. Is there a reason for this? (We should probably have a linter to ensure consistent formatting)
My only concern is the extra indent space on wrapped lines. Is there a reason for this? (We should probably have a linter to ensure consistent formatting)
I added them because they were reported by make lint
(used by TravisCI) :shrug:
@felixxm looks good overall, thanks! Curious why you chose to drop the regular expressions and used path(...)
instead of re_path(...)
path()
is more readable and simpler, IMO, that's why we add it to Django, to avoid regular expression where they're not necessary (see release notes).
I can prepare later follow up PRs with removing Python 2 shims.
I can prepare later follow up PRs with removing Python 2 shims. Sounds great! I'll prepare a release once that is in
PR with the most obvious changes is ready, #399.
Coverage decreased (-0.2%) to 97.052% when pulling 0d7e289fe4890826d680b03145178d4670d908f1 on felixxm:django31-url-path into b66ddb4b0044c5a0f24b6a23d5387f68b6d7e577 on macropin:master.