macropusgiganteus / scrappy-web

Project for Technical Test
0 stars 0 forks source link

Start of the code review process šŸ‘‹ #8

Open malparty opened 3 weeks ago

malparty commented 3 weeks ago

Hello Phanupong, šŸ‘‹

Thank you for your effort on the code submission. I am Xavier Malparty, Team Lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.

[!NOTE] At this stage, no need to implement the issues in the code, you can just explain how you would implement them by adding a comment to the issue.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. šŸ¤˜

macropusgiganteus commented 3 weeks ago

Hi Xavier,

Thank you for your time in reviewing my submission. My name is Phanupong Inchan and you can call me Mos. I will begin answering the questions from now on.

malparty commented 3 weeks ago

Hi Mos,

My apologies for using the wrong name. I think I will change my technique and use the full name instead of picking the "first name" from the conversation history (and picking my teammate's name by mistake) šŸ™ˆ

I will review your answers this morning, thanks for your quick replies šŸ™Œ

malparty commented 3 weeks ago

Hi again @macropusgiganteus

Thanks for all your answers. I know have all the needed insights to complete the evaluation of your Code Challenge.

The TA team will contact you within 1 or 2 days.

Wish you a good day ahead,

Xavier

macropusgiganteus commented 3 weeks ago

Hello @malparty,

Thank you for taking the time to review my submission šŸ™ I would appreciate your insights on both the technical and non-technical aspects of this project. Your feedback will help me improve and become a better programmer. Additionally, any tips on Rails projects would be greatly appreciated.

I hope we have the opportunity to meet again in the future :)

malparty commented 3 weeks ago

Hi again,

For the technical insights, I believe the main ideas have been shared in the other issues ;-)

For the non-technical, it was a pleasure exchanging with you, keep your positive attitude toward feedback, this is a powerful tool to learn! :)