search

macss-modeling / General-Questions

A repo to post questions about code, data, etc.
0 stars 0 forks source link

Do we need to pull request for ps1? #6

Closed jinfei1125 closed 3 years ago

jinfei1125 commented 3 years ago

Hi, according to Benjamin's GitHub workflow tutorial video, we should create a pull request on the original repository to turn in the assignment. However, since our ps1 repository is directly under the repository macss-modeling, I don't find a place to create a pull request to the base repository. I guess only pushing our pdf to our private ps1 repository is enough?

pdwaggoner commented 3 years ago

Yeah, that workflow is excellent, but it was created prior to using GH classroom, so no need for a PR. Just make all commit necessary to ensure the final PDF is in your version of the private repo and you'll be good to go.