Closed Lucas-C closed 3 years ago
GitHup Actions pipeline result: https://github.com/voyages-sncf-technologies/orka-integrations/runs/2810307325
Thanks for the contribution. I have a few minor comments.
Comments answered. Thanks for the review!
Change made. I think this is ready to be merged
There are still two occurrences of the long syntax - in run.sh
and prepare.sh
. Can you check them out, please?
Done
Content of this PR:
shellcheck
static code analysis of the.sh
files inGitLab/scripts/
. This check could be extended to analyze more.sh
files of this repo later on.shellcheck
warnings on the scripts inGitlab/scripts/
$ORKA_ENDPOINT/token
is successful inprepare.sh
ConnectTimeout
of 60 seconds when performing the first SSH connection inprepare.sh