macteo / Marklight

Markdown syntax highlighter for iOS
Other
638 stars 44 forks source link

macOS Framework (Work in Progress) #7

Closed DivineDominion closed 7 years ago

DivineDominion commented 7 years ago

After the announcement in #5, here's the nearly finished macOS library version.

I have performed a few changes.

removeWholeAttributes() Problem

Here is the removeWholeAttributes() evidence :)

Before:

screen shot 2017-07-19 at 12 36 43

After typing, removing the styles:

screen shot 2017-07-19 at 12 37 15

macteo commented 7 years ago

Thanks for your great contribute. To solve the travis issue you should probably change the iPhone SE id to BA25BEF2-CAEF-4855-9BB3-63D0D6C4EEDD in the .travis.yml configuration file.

The issue probably affects also the develop branch but as I don't have plans to make other commits there you can change it directly here.

DivineDominion commented 7 years ago

@macteo Thanks for the Travis-hint! 👍

I have found a way to re-style the edited paragraph and the surrounding ones to support Setext headings. So I think this is now identical to what it did before on iOS :)

Energy consumption is crazy high when typing, though. All the regular expressions are probably doing this. But that's an improvement for another PR. Could you give it a run and try to use it in a CocoaPods project to verify I did nothing wrong? As far as I'm concerned, the changes are merge-able.

DivineDominion commented 7 years ago

Ah, nearly forgot: If you want me to change the version in this PR to save you some work, just say so.

codecov[bot] commented 7 years ago

Codecov Report

Merging #7 into develop will increase coverage by 16.28%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop       #7       +/-   ##
============================================
+ Coverage    71.33%   87.61%   +16.28%     
============================================
  Files            3        1        -2     
  Lines          607      210      -397     
============================================
- Hits           433      184      -249     
+ Misses         174       26      -148

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be0d997...8ebd893. Read the comment docs.

macteo commented 7 years ago

I'm gonna test CocoaPod as soon as possible, in the meantime please add yourself to the Acknowledgements if you like.

macteo commented 7 years ago

Feels good to me, as soon as it's merged I'm going to submit the CocoaPod update

DivineDominion commented 7 years ago

Sure, will do!