search

macterra / artx-market

Digital art exchange built on BTC/LN
https://artx.market/
MIT License
6 stars 5 forks source link

Must include https:// in link #178

Closed Pennycrumb closed 9 months ago

macterra commented 9 months ago

bad link (e.g. google.com) raises server error

artx-market-app-1       | 2023-11-17T16:55:33.613908811Z Error fetching profile data: TypeError: Cannot set properties of null (setting 'collections')
artx-market-app-1       | 2023-11-17T16:55:33.613942591Z     at Object.getAgentAndCollections (/app/xidb.js:364:27)
artx-market-app-1       | 2023-11-17T16:55:33.613947730Z     at /app/server.js:812:32
artx-market-app-1       | 2023-11-17T16:55:33.613951985Z     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
artx-market-app-1       | 2023-11-17T16:55:33.613956052Z     at next (/app/node_modules/express/lib/router/route.js:144:13)
artx-market-app-1       | 2023-11-17T16:55:33.613959994Z     at Route.dispatch (/app/node_modules/express/lib/router/route.js:114:3)
artx-market-app-1       | 2023-11-17T16:55:33.613964008Z     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
artx-market-app-1       | 2023-11-17T16:55:33.613968060Z     at /app/node_modules/express/lib/router/index.js:284:15
artx-market-app-1       | 2023-11-17T16:55:33.613972051Z     at param (/app/node_modules/express/lib/router/index.js:365:14)
artx-market-app-1       | 2023-11-17T16:55:33.613976229Z     at param (/app/node_modules/express/lib/router/index.js:376:14)
artx-market-app-1       | 2023-11-17T16:55:33.613980160Z     at Function.process_params (/app/node_modules/express/lib/router/index.js:421:3)
artx-market-app-1       | 2023-11-17T16:55:33.614771606Z GET /api/v1/profile/google.com 500 5.186 ms - 41
macterra commented 9 months ago

Fixed in https://github.com/macterra/artx-market/commit/8e1075f55cc2333f591bfbc8bc0f6d03883389fb

Pennycrumb commented 9 months ago

error occur for certain urls on mobile Screenshot_20231120_235254_Chrome Screenshot_20231122_233645_Chrome Screenshot_20231122_233700_Chrome

macterra commented 9 months ago

Those are all correct. https://lucifer.com, https://monkeybat.com and https://www.monkeybat.com are invalid.

http://lucifer.com, http://monkeybat.com and http://www.monkeybat.com (without the s) are valid and will work if entered.

macterra commented 9 months ago

Agreed to remove https:// from text prompt

Pennycrumb commented 9 months ago

Tested