Closed Muintoll closed 3 years ago
mactso
commented
3 years ago Thanks for the feedback. I'll give it a look and give you some feedback within 24 hours.
As a quick response: It looks like it occurs when a skeleton tries to grow a giant mushroom. So you can turn off that feature and the crash should stop.
It's probably interaction with another mod because we've never seen this error before. maybe an alternate grass block.
Please let me know if removing "mushroom" fixes it.
Jackiecrazy
commented
3 years ago I have the exact same crash, removing mushrooms does not fix it for me. I can no longer play my save because it crashes every few seconds. It appears to be Biomes You'll Go's grass blocks?
Darkmega18
commented
3 years ago I have this also. :< here's a similar crash to do with grass and cows on them that I put in the linked byg issue also. https://pastebin.com/rjCkmJwx
mactso
commented
3 years ago I see the reference to BYGGrassBlock. I'll keep working on this. Hopefully soon. I've tested with BYG for hours without a problem so not sure what's up.
Darkmega18
commented
3 years ago try every variant of grass they add and turn up the frequency of your stuff doing things so they do the thing eventually? I was hanging out in the plains for mine for a time and it didn't crash for a while. so it's probably not constant. but potentially once Jackie had it it kept happening cause of other animals or the animal trying to keep doing it's thing and crashing?
I know there was one of those big mountains with the stone based grass near me. and several types of glowy forest too.
do you try to eat from the stone grass and it can't figure out what to transform it to? since the herd of cows was close to the base of that mountain with the stone grass. But I'm not super sure on the mechanics you do with them.
mactso
commented
3 years ago That's some good feedback.
You should be able to safely disable regrowth and play your saved games until i get this fixed. I'm working on this and could have a fix any day. I might also be able to bulletproof the code so it handles the potential instead of propagating it upwards. That would help bulletproof it against future unknown blocks.
Darkmega18
commented
3 years ago Just letting you know what I noticed. anything I can do to get a bug fixed.
I did like jackie and offed the animal based config and just kept the villager stuff going for now.
mactso
commented
3 years ago I've isolated the error
If you set debuglevel to 2, then you should see a message in the log like:
System.out.println(key + " trying to grow plants sat " + eX + ", " + eY + ", " + eZ + ".");
On the next line it refers to:
(ServerWorld) eventEntity.world,
eventEntity.world.rand,
getBlockPos(eventEntity),
eventEntity.world.getBlockState(getBlockPos(eventEntity))
One of these is null.
I've confirmed it can't be the world, or the blockpos so it is (unlikely) the random number generator
or (likely) the block state of the block.
I'm going to bulletproof the code and expect to upload a fix tonight.
mactso
commented
3 years ago Okay, it turns out that only daffidils and poppies will grow on the overgrown (spreadable) stone and they grow a lot- like place that would be grass is a daffidil or a poppy.
I'm thinking I need to detect the spreadable stone and not grow on it. It's an odd little block that is sort of like a grass block and sort of not. And it's partially growable and partially not.
Permanent Fix is not likely tonight but I'll post a hotpatch that will hopefully block the crashes. Please let me know.. The side effect is they will eventually grow flowers (about every 4 minutes) and then eventually eat the flowers (about every 4 minutes after flowers are grown) and then sometimes convert the byg stone to normal minecraft dirt about 1/4th of the time when they eat the flowers (about once every 4 minutes).
Darkmega18
commented
3 years ago well ok. when I get it I'll reset my config and get the animals doing their thing and I'll take a look. and I appreciate the keeping us up to date with your musings as you worked it out.
mactso
commented
3 years ago Lupicus dug into why this is happening and it looks like the BYG code is referencing a height map that only exists at WorldGen time when you call the grow() method.
I basically put on a belt, boots and suspenders. I put additional code at the top to avoid entering it. I added extra instrumentation (debug message) if debugging is turned on. I put a "try catch" block around to catch an exception if it occurs on the grow() attempt. I added extra debugging messages to identify if an exception occured.
Crossing my fingers.
Let me ask you... do you prefer that if animals grow flowers and eat them, they can slowly transform the grassy "overgrown rock" to dirt or that regrowth skip/ignore the grassy "overgrown rock"
mactso
commented
3 years ago Lupicus has updated the ticket at BYG.
Darkmega18
commented
3 years ago Let me ask you... do you prefer that if animals grow flowers and eat them, they can slowly transform the grassy "overgrown rock" to dirt or that regrowth skip/ignore the grassy "overgrown rock"
the overgrown rock is kinda just a terrain feature of some of those special mountainous regions, it'd probably be fine that they don't try to grow stuff there if there is issues? just to keep the area uniform and stuff.
does it grow anything if you bonemeal it and stuff? I never actually tried. too busy wandering aimlessly and being slapped in the face with bugs in worlds that I did have some. :V if they eat flowers and stuff I think vibrant journeys in my pack can spawn rocks etc on it and I swear there was tall grass on it too. so if they can eat the tall grass or flowers and then bonemeal the area or something, thats fine, just don't eat the... hard mossy dirt grass stone... lol
mactso
commented
3 years ago Actually, if you bone meal it, it also crashes. It's the bug causing the crash. Apparently as of the may 6th release it refers to an object that only exists when a chunk is generated. So it's "null" at run time.
It can grow flowers when bonemealed even tho it has a null exception.
Darkmega18
commented
3 years ago WELP, that sounds like an issue of itself also that they'll need to patch up...
mactso
commented
3 years ago It is but when a player does it, it catches the exception and prints it to the log instead of crashing. So probably low priority for them.
Is it working again for you? It's working in my test environment so if it is working for you guys, I'll close the issue.
Darkmega18
commented
3 years ago it seems fine. hopefully. :) although haven't given it a real good go yet cause of issues with server side lag when trying to play with friends cause other reasons.
mactso
commented
3 years ago Thanks for the feedback ! Going to close this one.
Forge Version : 3.1.16 Minecraft Version: 1.16.5
After a couple of hours of playing on Centos 7 server with a couple of friends server crashed and and showed me this in logs:
I suppose the crash was caused by Regrowth, maybe one of the villagers did an action that didn't work well, but after restarting the server world goes a couple of ticks back and works okay till the villager's bugged action happens again.
I can provide the actual logs and mods that we used if that's needed, maybe it's just a conflict between the mods.