mactso / Regrowth

Creatures eat/destroy or grow grass as they move around.
MIT License
1 stars 5 forks source link

Incompatibility with Natural Progression #27

Closed emanuele246gi closed 1 year ago

emanuele246gi commented 1 year ago

Forge Version: 40.1.69 Minecraft Version: 1.18.2

Describe the bug Villagers do not build walls on blocks with pebbles and sticks, despite being like grass: that disappear when a block gets placed on them.

To Reproduce Steps to reproduce the behavior:

  1. Find a village
  2. Wait until they start build walls
  3. Notice when they skip a spot occupied by a pebble or a stick (if not, you should be able to reproduce this even by manually placing them.

Expected behavior To substitute them just like tall grass or flowers

Screenshots 2022-08-06_15 14 45

mactso commented 1 year ago

Thanks for your report. That's going to be tough to fix since I can't compile against their files.

I'll look into it this week.

Can you look at them with F3 and give me the "modname:blockname"?

emanuele246gi commented 1 year ago

Sure! natprog:stone_pebble natprog:andesite_pebble natprog:diorite_pebble natprog:granite_pebble natprog:sandstone_pebble natprog:red_sandstone_pebble natprog:tuff_pebble natprog:deepslate_pebble natprog:dripstone_block_pebble natprog:netherrack_pebble natprog:end_stone_pebble

Here there are stone types from other mods: natprog:quark_limestone_pebble natprog:quark_jasper_pebble natprog:create_asurine_pebble natprog:create_crimsite_pebble natprog:create_limestone_pebble natprog:create_ochrum_pebble natprog:create_scorchia_pebble natprog:create_scoria_pebble natprog:create_veridium_pebble

And here it is the stick: natprog:twigs

Thank you for your effort and patience, man!

mactso commented 1 year ago

Thanks!

Looks like I can look for natprogs:*pebble and natprogs:twig.

emanuele246gi commented 1 year ago

Thank you!

mactso commented 1 year ago

Sure. I'll still need to do some new program to see them on the ground and remove them so it will be a little bit. But definately as part of going to 19 and the change will be in 18 too.

mactso commented 1 year ago

Have a friend who is getting major surgery in 8 days so that may delay it.

emanuele246gi commented 1 year ago

No problem man, I'm not in a hurry for this

mactso commented 1 year ago

I've started work on this now.

mactso commented 1 year ago

image

This issue is fixed in version 31 for 1.18.1 now. The code changes are in for 1.18.2 (the version you are in) and I'll test them tomorrow (it's 4am. lol).

Then I'll do 1.19.1 for forge and fabric. May do a 1.18.2 for fabric depending on how hard it looks.

emanuele246gi commented 1 year ago

Thank you so much!

mactso commented 1 year ago

1.18.2 is submitted for approval.

Please let me know if it works and we can close the issue.

emanuele246gi commented 1 year ago

Sorry for the long wait, but yes! It works! Thank you so much man!