search

macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.51k stars 684 forks source link

glyphs rendering issue #1049

Open cridemichel opened 4 years ago

cridemichel commented 4 years ago

Describe the bug If I disable the option 'Use Core Text Renderer" and I set a font size larger than h18 (e.g. h19), I get vertical bars after right separators (e.g. look on the right of the following image after "5%")

Schermata 2020-05-30 alle 10 42 33

This is with Hack Nerd Font but note that I obtain this behavior with all fonts I have installed, i.e. FiraCode, Meslo, Hack Nerd Font Mono, JetBeans, JetBeans Mono, etc.

To Reproduce Detailed steps to reproduce the behavior:

  1. Install the "lightline" plugin (see https://github.com/itchyny/lightline.vim)
  2. Install the "Hack Nerd Font" (see https://github.com/ryanoasis/nerd-fonts)
  3. Add following settings to your .vimrc: 
    let g:lightline = {
  \ 'separator': { 'left': '_LS_', 'right': '_RS_' },
  \ 'colorscheme': 'deus',
  \ 'active': {
  \   'left': [ [ 'mode', 'paste' ],
  \             [ 'relativepath', 'extraflags', 'gitstat'] ],
  \   'right': [ [ 'lineinfo' ],
  \              [ 'percent' ],
  \              [ 'fileformat', 'fileencoding', 'filetype' ], 
  \              [ 'linter_checking', 'linter_errors', 'linter_warnings', 'linter_ok' ] 
  \            ]
  \ },
  \ }

    where LS and RS are left and right triangular separators as shown in the above image which I uploaded

Environment (please complete the following information):

ychin commented 4 years ago

Sorry for the late response, but Core Text renderer should always be on and the option is mostly there for backwards compatibility reasons. I would probably remove / deprecate option soon. Why did you disable that option?

cridemichel commented 4 years ago

Dear Yee Cheng, I disabled the core text rendered since it is slower and from time to time I get garbled text using it when scrolling,

best Cristiano

Cristiano De Michele cristiano.demichele@gmail.com

Il giorno 11 ago 2020, alle ore 12:03, Yee Cheng Chin notifications@github.com ha scritto:

Sorry for the late response, but Core Text renderer should always be on and the option is mostly there for backwards compatibility reasons. I would probably remove / deprecate option soon. Why did you disable that option?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/macvim-dev/macvim/issues/1049#issuecomment-671853560, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADU4YGU3MH3WMDWTQOKOZATSAEJNJANCNFSM4NOTREWA.

ychin commented 4 years ago

Ok. @cridemichel I think at this point you should probably consider non-Core Text path deprecated, and my current plan is to start deprecating it and merging the stateful renderer (which improves scrolling performance) by next release. As such, we probably won't actively fix bugs in the old renderer.

cridemichel commented 4 years ago

ok best C.

Cristiano De Michele cristiano.demichele@gmail.com

Il giorno 26 ago 2020, alle ore 04:54, Yee Cheng Chin notifications@github.com ha scritto:

Ok. @cridemichel https://github.com/cridemichel I think at this point you should probably consider non-Core Text path deprecated, and my current plan is to start deprecating it and merging the stateful renderer by next release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/macvim-dev/macvim/issues/1049#issuecomment-680451561, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADU4YGR2AK3GFT267CROF5LSCR2OLANCNFSM4NOTREWA.