search

macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.53k stars 685 forks source link

Change ga_add_string to ga_copy_string in MMBackend.m #1228

Closed limintang closed 2 years ago

limintang commented 2 years ago

Patch 8.2.4040 missed this change in MMBackend.m, creating an issue that crashes MacVim when multiple files are dropped into MacVim window.

ichizok commented 2 years ago

ref #1227

ichizok commented 2 years ago

Thank you, but I think better to remove vim_free(escapedFname) rather than changing to ga_copy_string(). (to be accurate, need check the result of ga_add_string() and do vim_free() if failed)

limintang commented 2 years ago

Thank you, but I think better to remove vim_free(escapedFname) rather than changing to ga_copy_string(). (to be accurate, need check the result of ga_add_string() and do vim_free() if failed)

Thanks. I'm not the expert on MacVim development; this patch merely helped me to resolve this issue locally. If there is a better solution, feel free to ignore mine.😀

ichizok commented 2 years ago

I just merged it. Thank you 👍