search

macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.53k stars 685 forks source link

mistake in wiki page 'Building' #1239

Closed mzlogin closed 2 years ago

mzlogin commented 2 years ago

In section 'How to get the MacVim source code': https://github.com/macvim-dev/macvim/wiki/Building#how-to-get-the-macvim-source-code

$ git clone git://github.com/macvim-dev/macvim.git

should be

$ git clone git@github.com:macvim-dev/macvim.git

or some error may occurs:

The unauthenticated git protocol on port 9418 is no longer supported. Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

eirnym commented 2 years ago

Hi @mzlogin

Nice catch! Could you make a PR to fix this issue?

mzlogin commented 2 years ago

Hi @eirnym

I'd like to make a PR, but as I know, GitHub doesn't support pull requests for the wiki repository, only the main repository.

ref https://stackoverflow.com/questions/10642928/how-to-pull-request-a-wiki-page-on-github and https://github.com/isaacs/github/issues/333

eirnym commented 2 years ago

It's a shame that GitHub still not allow to fix wikis via PRs

mzlogin commented 2 years ago

I agree 😢

So would you please fix it?

ichizok commented 2 years ago

Thank you, fixed it.