macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.47k stars 680 forks source link

Checkbox for Smooth Scrolling doesn't completely show in Preferences #1281

Closed wbpayne22902 closed 1 year ago

wbpayne22902 commented 1 year ago

Steps to reproduce

  1. Clone the macvim repository and compile and run
  2. Open the Preferences window
  3. You will see that the sizing of the window is off and the checkbox is cut off at the bottom of the dialog. Screen Shot 2022-09-11 at 1 29 05 PM

Expected behaviour

The checkbox should be completely visible

Version of Vim and architecture

Macvim HEAD commit fcd7bd4 Vim version 9.0.420, GUI, arm64

Environment

Mac OS Monterey 12.5.1 arm64 Terminal not relevant as issue is with GUI mode. zsh 5.8.1

How MacVim was installed

Clone of repository from GitHub and manual build.

Logs and stack traces

No response

Vim configuration where issue is reproducable

No response

Issue has been tested with given configuration

Issue has been tested with no configuration

Other conditions

ychin commented 1 year ago

Oh yeah I didn't test for the case where sparkle is disabled and the preference pane gets resized to adjust. Will fix.

Btw I'm assuming you have Sparkle disabled? I didn't see that in your post but I think that has to be the case for your issue to prop up.

ychin commented 1 year ago

Also, not to disappoint you this is "smooth resizing" , not "smooth scrolling". Smooth scrolling is not going to come for a while, and only if I could find a good way to do it in a stable fashion.

wbpayne22902 commented 1 year ago

Sorry about that, I meant smooth resizing. For some reason my brain thinks one thing and writes another. Also, sorry for neglecting to mention that I had Sparkle disabled. Thanks for the fix, I've tested it and it works great.