search

macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.47k stars 680 forks source link

Update Python vimrc detection to 3.10 #1283

Closed ychin closed 1 year ago

ychin commented 1 year ago

CI build has been updated to build MacVim against Python 3.10, so we want to update the other detection to use 3.10 as well. Also added a comment to CI file to make sure we remember to update the vimrc file when updating the version.

ychin commented 1 year ago

I thought about using the "Current" version (/opt/homebrew/Frameworks/Python.framework/Versions/Current/Python) instead of 3.10 when building in CI. This way, we don't have to keep updating it, and it's more lenient to users using newer/older versions of Python. However, I'm not 100% sure what kind of knock-on effects there are with doing this as I don't really know under what circumstances will the "Current" link get updated or whether it is guaranteed to exist or not, and also technically using a different version of Python than the linked one could potentially lead to problems (that said, it's not like we care about this for Ruby / Lua / etc).

As long as we keep updating Python to the latest version and routinely publish new builds this shouldn't be too much of a problem in practice.