macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.47k stars 680 forks source link

Add File.Close support for terminal which also makes it work for Cmd-W #1310

Closed ychin closed 1 year ago

ychin commented 1 year ago

Since Vim upstream added support for :confirm q for terminals, we can now get our File.Close menu to work properly for them as well. This also means Cmd-W (which is bound to that menu item) works too.

Also just add validateMenuItem: for MMAppController even if we are just returning YES. This makes it semantically clearer and is easier to debug.