macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.47k stars 680 forks source link

Fix popup test failure, and clean up MacVim error codes #1327

Closed ychin closed 1 year ago

ychin commented 1 year ago

Fix failure in Test_popup_command. The test assumes a certain PopUp menu layout but we recently added a new "Look Up" menu item. Make sure the test removes those non-standard menu items before progressing the test.

Also, while we are at it, make sure the showdefinition() command will fail when not in GUI mode so it doesn't queue up the command queue. Also, convert the E??? error codes to proper error codes (and using a postfix "-M" to make sure they don't conflict with future Vim error codes) so they can be looked up in documentation.