Tabs crash latest macvim

9mm commented 1 year ago

Steps to reproduce

I notice with the latest homebrew version of macvim when i opened it it crashed immediately. when I went through line by line to figure out if it was related to an installation issue or a config issue, i narrowed it down to this single line:

" show buffer tabs
set showtabline=2

I notice even if i delete the entire contents of .vimrc except for that line it still crashes, so the steps to reproduce it are very easy

Expected behaviour

It should not crash

Version of Vim and architecture

it crashes so i cant run that, see below:

Environment

VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Sep 15 2022 18:56:17) macOS version - x86_64 Included patches: 1-472 Compiled by Homebrew

==================

Ventura: 13.1 (22C65)

How MacVim was installed

Homebrew

Logs and stack traces

No visible log, just immediately closes 1 second after opening

 mvim --clean does work properly

Vim configuration where issue is reproducable

No response

Issue has been tested with given configuration

[X] by running MacVim.app from GUI macOS interface
[ ] by running vim/gvim/etc installed by MacVim
[ ] by running other versions of vim (e.g. /usr/bin/vim)

Issue has been tested with no configuration

[X] by running mvim --clean (or gvim, supplied by MacVim distribution)
[ ] by running vim --clean (in terminal, supplied by MacVim distribution)
[ ] by running vim --clean (in terminal, other suppliers, e.g. /usr/bin/vim)

Other conditions

[ ] The both Homebrew packages "vim" and "macvim" are installed

9mm commented 1 year ago

As a follow up, just all tabs entirely crash... if I hit command+T to make a new tab (after disabling that option) mvim just crashes

RStankov commented 1 year ago

I have the same issue from earlier this morning. Even without my vimrc it crashes when I open a new tab.

I noticed that same version downloaded via:

https://github.com/macvim-dev/macvim/releases/download/release-174/MacVim.dmg

Works as expected.

eirnym commented 1 year ago

dup of https://github.com/macvim-dev/macvim/issues/1333.

alecernas commented 1 year ago

I have the same issue when opening a new tab

$mvim --version
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Sep 15 2022 18:56:17)
macOS version - arm64
Included patches: 1-472

SO Ventura 13.0

eirnym commented 1 year ago

@ychin could I ask to release a new version of MacVim with this fix?

fahasch commented 1 year ago

For the time being, brew install --HEAD macvim installs the latest version of macvim where the issue has been fixed.

jmarrec commented 1 year ago

For the time being, brew install --HEAD macvim installs the latest version of macvim where the issue has been fixed.

Have you got a PR / commit that fixed it? Or is it just the fact that by doing --HEAD you are compiling it from source that makes it work?

Anyways, it does work when compiled from source via --HEAD, so thanks!

fahasch commented 1 year ago

The latter: --HEAD compiles the latest version of the source code where the issue is fixed. For a bottle version, we most likely have to wait for the release 175 of macvim.

ychin commented 1 year ago

One #1356 is in, I'll make sure there are no straggler issues that i need to fix up and upstream Vim is stable and I'll push out the release. Sorry for the delay. 🙏

ychin commented 1 year ago

This should be fixed since r176 (r175 was skipped because I missed a case where tabs could still end up crashing and I released a fix for that) was just released. Closing this for now. If you are using Homebrew, it usually takes a couple days for them to update the formula/bottle for a new release.

jmarrec commented 1 year ago

Thanks a lot @ychin !

macvim-dev / macvim