macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.47k stars 680 forks source link

Fix `set fullscreen` not working after upstream Vim merge #1379

Closed ychin closed 1 year ago

ychin commented 1 year ago

The recent upstream Vim merge (v9.0.1365) contained a lot of refactoring in the option setting code. Handling option setting was now done via a standardized callback, with a struct optset_T. In resolving the upstream merge conflicts, did_set_fullscreen was erroneously using the wrong value from the union (should be using boolean instead of number) which leads to it occasionally giving unpredictable results. Fix the bug.

Note that the bug seems a little unpredictable since it depends on compiler specifics. The only way it was known to trigger was by set diff followed by set fullscreen.

Fix #1378