Welcome message's `:` are not aligned

macvim-dev / macvim

Vim - the text editor - for macOS

https://macvim.org

Vim License

7.47k stars 680 forks source link

Welcome message's `:` are not aligned #1380

Closed dantezhu closed 1 year ago

dantezhu commented 1 year ago

Steps to reproduce

open macvim
show the welcome msg, but : are not aligned

Expected behaviour

: should be aligned like this:

Version of Vim and architecture

9.0.1276

Environment

OS: macos 13.2.1 (22D68)

How MacVim was installed

brew

Logs and stack traces

No response

Vim configuration where issue is reproducable

No response

Issue has been tested with given configuration

[x] by running MacVim.app from GUI macOS interface
[x] by running vim/gvim/etc installed by MacVim
[ ] by running other versions of vim (e.g. /usr/bin/vim)

Issue has been tested with no configuration

[ ] by running mvim --clean (or gvim, supplied by MacVim distribution)
[ ] by running vim --clean (in terminal, supplied by MacVim distribution)
[ ] by running vim --clean (in terminal, other suppliers, e.g. /usr/bin/vim)

Other conditions

[ ] The both Homebrew packages "vim" and "macvim" are installed

ychin commented 1 year ago

Huh, this only seems to happen when columns is even. If it's odd numbered it will work. I will fix it up.

Just curious, do you use MacVim with locale set to Chinese? MacVim still has quite a few unlocalized pieces (the settings dialog, random texts that are MacVim-specific, documentation) so I'm curious how the user experience is.

dantezhu commented 1 year ago

Thanks ychin. MacVim works very well in Chinese environment.

The only thing that makes me uncomfortable is that when using LeaderF to input Chinese, it will look like this:

I know it can be solved by canceling Draw marked text inline, but this will cause the original input characters to be hidden, so it is not a perfect solution.

I have seen similar issues mentioning this problem, and it seems that the bottom layer needs to be modified to solve it, it may be difficult to solve.

Everything else works fine, thanks a lot for your contribution!

ychin commented 1 year ago

Ah yes, getting input to work better is actually quite high on my list to do next, so this will be tackled soon. In particular you should not need to disable "draw marked text inline" if everything worked and we shouldn't have two settings that are both broken a little bit in their own ways. Getting input methods to work better in non-insert mode situations (including your use case, or just using r) is on my list but I need to think a little about the best way to tackle them first, but I don't think there's anything in Vim that's particularly problematic. It's mostly a MacVim-layer issue. So there should be a fix in the future soon (disclaimer: "soon" has a flexible definition…) !

dantezhu commented 1 year ago

Haha, thank you very much! looking forward to the fix~ 😁