search

macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.47k stars 680 forks source link

CI: Bump actions/cache from 3 to 4 #1487

Closed ichizok closed 2 months ago

ychin commented 2 months ago

For some reason this is failing the macos-12 runner tests in test_playsound. There was a fix in CI to enable sound permissions but it's supposed to only be needed for macos-14. I wonder if the "Grant microphone access for macos-14" step in ci-macvim.yaml needs to just include every version of macOS, somehow.

ichizok commented 2 months ago

Based on my investigation; macos-12 runner runs on any one of (at least) 3 machines:

$ log show --no-pager | head -n2

1

Timestamp                       Thread     Type        Activity             PID    TTL  
2024-03-29 02:09:32.000000-0700 0x0        Timesync    0x0                  0      0    === system boot: 8F30006D-B8A0-48E7-8749-DF48371DD59C

2

Timestamp                       Thread     Type        Activity             PID    TTL  
2024-04-04 13:48:52.000000-0700 0x0        Timesync    0x0                  0      0    === system boot: F1D48C73-D273-4888-98C5-AAE42396C09D

3

Timestamp                       Thread     Type        Activity             PID    TTL  
2024-04-18 12:43:46.000000+0000 0x0        Timesync    0x0                  0      0    === system boot: 3B270419-7E13-4B6D-B7DE-4AD0B8459F3F

1 and 2 have no audio device, and 3 has NullAudio device.

$ system_profiler SPAudioDataType

1,2

Audio:

    Devices:

3

Audio:

    Devices:

        Null Audio Device:

          Default Input Device: Yes
          Default Output Device: Yes
          Default System Output Device: Yes
          Input Channels: 2
          Manufacturer: Apple Inc.
          Output Channels: 2
          Current SampleRate: 44100
          Transport: Virtual
          Input Source: Data Source Item 0
          Output Source: Data Source Item 0

$ ls -l /Library/Audio/Plug-Ins/HAL

1,2

ls: /Library/Audio/Plug-Ins/HAL: No such file or directory

3

total 0
drwxr-xr-x  3 root  wheel  96 Jun 13  2023 NullAudio.driver

Therefore test_sound fails when it runs on 1 or 2 since no audio device.

Ref: