search

macvim-dev / macvim

Vim - the text editor - for macOS
https://macvim.org
Vim License
7.53k stars 685 forks source link

MacVim draws FZF windows slower than Terminal.app #881

Open tambourine-man opened 5 years ago

tambourine-man commented 5 years ago

When using FZF.vim, MacVim draws considerably slower than Terminal.app.

It's particularly noticeable on large screens. Where Terminal seems to simply jump the cursor to the bottom of the screen, MacVim appears to move it line by line until it reaches the bottom.

Please check the GIF below MacVimDrawingSpeed

eirnym commented 5 years ago

Do the changes in #858 fix this?

tambourine-man commented 5 years ago

Not really. To be clear, I downloaded the source from Github (as there doesn't seem to be a binary release yet), ran ./configure && make. The final app bundle version is 8.1.1270 (155). Is that it?

eirnym commented 5 years ago

Have you downloaded the branch by s4y, or just master branch?

I see the same vim patch version

eirnym commented 5 years ago

in other words, could you check the latest commit message and add a comment to that PR?

It has big performance boost in comparison to what we have in the master, but it's not perfect yet.

eirnym commented 5 years ago

Could you also put an exact test case to test performance difference without gaining a knowledge of FZF.vim?

tambourine-man commented 5 years ago

No, I downloaded and compiled from master. You mean this, right? https://github.com/s4y/macvim/tree/stateful-render

Just tried and it seems just as slow.

It doesn't appear at first to be a rendering issue, but instead, it's as if MacVim is moving the cursor down one line at a time as fast as it can, while Terminal Vim just places it at the bottom in one go. But I could be wrong, of course.

I haven't seen the issue outside FZF.vim, but I'll see if I can create a test case without it.

sstepashka commented 1 year ago

I have exactly the same issue... right now. Was there any fix for that? I think, fzf uses popup and it takes a while to draw pop up borders... and it happens for both GUI and terminal version.

ychin commented 1 year ago

What’s “fat”? Do you mean fzf? The issue was supposed to be fixed but I mostly left it open so I can close it when I add Metal rendering.

if the terminal version is slow too that could be an issue with the plug-in rather than MacVim itself. But it really depends if you meant fzf or another plugin. It would be useful if you have a short clip to show what the issue is.

sstepashka commented 1 year ago

@ychin yeah, I meant fzf. Sorry for the typo. The symptoms are the same as on the video for iterm2, alacrity, and GUI. I found a bug only for Mac version and I do not have a chance to test on a different platform...

ychin commented 1 year ago

Have you tried regular Vim? If it happens for iTerm and Alacritty rather than just GUI then this seems to me like a Vim / fzf rendering issue, and not specific to MacVim.