Remove Unneeded Functionality

macxred / cashctrl_api

Python client for the CashCtrl REST API

MIT License

0 stars 0 forks source link

Remove Unneeded Functionality #10

Closed lasuk closed 4 months ago

lasuk commented 4 months ago

As decided in our meeting, we need the core functionality of CashCtrlAPIClient is:

base request (get, post, put, delete)
file_upload
list_categories

In addition, we want to implement a specific functionality required at our company

mirror_files: Recursively mirror a folder on the local file system to CashCtrl, mapping local folders to remote categories.

All other functions can be removed.

lasuk commented 4 months ago

In addition, we would like to slightly simplify CashCtrlAPIClient. file_upload():

file_upload(self, local_path, remote_name=None, remote_category=None, mime_type=None)

Changes:

local_path must be a valid path to a local file.
remote_name: defaults to basename(local_path)
remote_category is now in integer id or None.

chappi commented 4 months ago

Two remarks:

the 'filepath_list' stays in the code until 'mirror_files' is ready
in '_request' the 'params' parameter also had to get the 'flat-treatment' (see #4)

chappi commented 4 months ago

This branch builds upon the 'hps/extend-filelist' branch which has to be rebased. Not sure what will happen but I'll need to rebase (and solve the conflicts) in this branch then