search

macxred / cashctrl_api

Python client for the CashCtrl REST API
MIT License
0 stars 0 forks source link

mirror function to synchronize local files/folders with remote files/categories #17

Closed chappi closed 4 months ago

chappi commented 4 months ago

In the limited tests the functionality worked well, ...but:

lasuk commented 4 months ago

Hi Hans-Peter

I do not really understand what you’re expecting from me or what I am supposed to comment on. Please direct me more clearly so that you get the comment you are looking for.

Enjoy the momos, Lukas

On 12 Apr 2024, at 12:18, Hans-Peter @.***> wrote:

In the limited tests the functionality worked well, ...but:

file update when local modified date is after the remote date is not handled (Reason: the basic file update functionality is not yet implemented) it needs more testing (e.g. delete all remote files/categories, create initial state etc.) NOTE from the non-executed testcode: "It must be decided how often and how far we want to test. It might be a bit overwhelming if we fully delete and recreate categories and files on each single commit..." You can view, comment on, or merge this pull request online at:

https://github.com/macxred/cashctrl_api/pull/17

Commit Summary

3667f8e https://github.com/macxred/cashctrl_api/pull/17/commits/3667f8e8948a9e0a7a6a4682b381141aa15c3366 update file mockup for mirror testing 5a5a7e7 https://github.com/macxred/cashctrl_api/pull/17/commits/5a5a7e798c2bcbaed3583a2b4f2ff82cc601619e update again file mockup 12651e4 https://github.com/macxred/cashctrl_api/pull/17/commits/12651e43ffd329e8f4f671c588b7de08ed2b04b8 add category level, Mockup with nothing in it 1c65e4f https://github.com/macxred/cashctrl_api/pull/17/commits/1c65e4f6c64cfe5c290bf30b15370b6ae543e272 Support categories in file upload (fix) 21419b4 https://github.com/macxred/cashctrl_api/pull/17/commits/21419b47983bfb10fa1d097aab846ea23478fbeb Add 'level' and 'rootpath' (for 'file' object) fields in category listing d579d6b https://github.com/macxred/cashctrl_api/pull/17/commits/d579d6b60a4e72907ae6ff97bc0cfbadd0a4c3d1 Add mirror_files incl. some helper functions 50ea055 https://github.com/macxred/cashctrl_api/pull/17/commits/50ea055a8b3c54a3baa6700ac67927c488964cee add mirror_files test (w/local successful script code) File Changes (23 files https://github.com/macxred/cashctrl_api/pull/17/files) M cashctrl_api/api_client.py https://github.com/macxred/cashctrl_api/pull/17/files#diff-62509a550f2d5254815f927bbd9aa1092662624f7874f77bbbe9913b54f245d1 (165) A res/FileMockup/Init/0All/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-7047ea01b7515ad535fe2c0836fb87de247aea26df2fbac8e96180baf7908ef0 (1) A res/FileMockup/Init/0All/1Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-ac6dfd7ad180c1eac736efe710a9c54bb365e0386eefc02fd74abd5c043f746c (1) A res/FileMockup/Init/0All/2Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-c123e9c5f15c7083ecc99dc9cccc1d40ddf81c9792f3bcdbfb67d2fa341e92c8 (1) A res/FileMockup/Init/0All/2Hallo/21Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-c8fe57274eece3a27d2b0032a69aa97fb3f5eabb610ca06b35aaab387a10cbea (1) A res/FileMockup/Init/0All/2Hallo/21Hallo/211Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-2faa1cce22d6eae40c737229c64ea5e4cb3d3918caec2ab1105366b2d5ad4171 (1) A res/FileMockup/Init/0All/2Hallo/22Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-204124533ecac73006a9fae795235d16165270689e35fbec103ef9609bde5063 (1) D res/FileMockup/Init/readme.md https://github.com/macxred/cashctrl_api/pull/17/files#diff-935220959d4e1af2609b344b29404bcf06f95707384f1f13c984bc48e6407cb5 (5) A res/FileMockup/Nothing/0All/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-5d0df7f858426c3dd10bb454826b44bc37b50f77bbd1a26ea044309a64ab9a3c (1) A res/FileMockup/Rev1/0All/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-310794a2525ecb74f911fe54b028bc4b636c166f3c97279b02a08c1bfd0a6884 (1) A res/FileMockup/Rev1/0All/1Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-b1857ead012eed7488958421e3f5d296b2122bd7dcfb2b0deac3e60da369f698 (1) A res/FileMockup/Rev1/0All/1Hallo/1welt.txt https://github.com/macxred/cashctrl_api/pull/17/files#diff-0e90a060e9ce6dbb8ec07c21fbf4d6efd93498ff83560ef92a16723d78d29ea0 (1) A res/FileMockup/Rev1/0All/2Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-71d99e2fce0d8eb3388e5ad712d36f57262a747575ff765d4bc66aa0157cb342 (1) A res/FileMockup/Rev1/0All/2Hallo/21Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-257cb3b02da3ac3ee1f992324b311da1fb38eddaf01ad625926d2ef35252f2df (1) A res/FileMockup/Rev1/0All/2Hallo/21Hallo/211Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-da5712936074129c0f565f6238eb42a9db7d4d5b138aa01454cf8ce8489ea2ce (1) A res/FileMockup/Rev1/0All/2Hallo/21Hallo/211Hallo/211welt.txt https://github.com/macxred/cashctrl_api/pull/17/files#diff-5fc722b941728e9880dc45ef944758dd60061ddbbac47984cdf58b95679cdc40 (1) A res/FileMockup/Rev1/0All/2Hallo/21Hallo/21welt1.txt https://github.com/macxred/cashctrl_api/pull/17/files#diff-17625427dd4d44cb92afd7f39311bf358261917a5127b75db6a53e181b867e81 (1) A res/FileMockup/Rev1/0All/2Hallo/21Hallo/21welt3.txt https://github.com/macxred/cashctrl_api/pull/17/files#diff-932037a1162d88cdc34a1129d5e959f613718b84e90108f8826728823edcf599 (1) A res/FileMockup/Rev1/0All/2Hallo/22Hallo/.gitkeep https://github.com/macxred/cashctrl_api/pull/17/files#diff-a1a8bc65ac4b3f46b92bba7cf09483453cdbe9bafe0cc5e4ab1fed7c2e998c5a (1) A res/FileMockup/Rev1/0All/2Hallo/2welt.txt https://github.com/macxred/cashctrl_api/pull/17/files#diff-67cc7c533550c7e3a7c4a9ea50f1b66ec5a2b7d54c5f73fdac425994330428ef (1) A res/FileMockup/Rev1/0All/3Hallo/31Hallo/311Hallo/311welt.txt https://github.com/macxred/cashctrl_api/pull/17/files#diff-582cc4ac446d3fdc3cb3acafb8d5b50af23baf80d3b57980af7dad78a67694a6 (1) A res/FileMockup/readme.md https://github.com/macxred/cashctrl_api/pull/17/files#diff-a5ae5602d864940c75d89601341a2938d38b7af4239b5c53796ae4d380571e19 (16) A tests/test_mirror_files.py https://github.com/macxred/cashctrl_api/pull/17/files#diff-0343adafbb220bc77cdc3749d84831c1cda7f92d27c6cc0eb647614070a1c04d (30) Patch Links:

https://github.com/macxred/cashctrl_api/pull/17.patch https://github.com/macxred/cashctrl_api/pull/17.diff — Reply to this email directly, view it on GitHub https://github.com/macxred/cashctrl_api/pull/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMXZTNCZ3AH2EUMJNY4G7LY46YIZAVCNFSM6AAAAABGD35C5SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTSNZQGIYDQNA. You are receiving this because you are subscribed to this thread.

chappi commented 4 months ago

Momos were great!! I'll ask later clearly, thanks

chappi commented 4 months ago

I don't know why the check fails on github. It runs locally. Error message below. I will disable the test again now.

=========================== short test summary info ============================ FAILED tests/test_mirror_files.py::test_mirror_files - Exception: root '/github/home/dev/prj/le24/dev/cashctrl_api/res/FileMockup/Init/0All' must be a directory ========================= 1 failed, 4 passed in 5.57s ==========================

[Edit]: maybe the $GITHUB_WORKSPACE env var would help? From SO

lasuk commented 4 months ago

Closed as incomplete.