Closed AlexTheWizardL closed 2 months ago
Thanks for the modifications. I've added further modifications as fdabbe8. @AlexTheWizardL: Please shout if you disagree.
@lasuk Your changes look good to me
The code looks good to me and passes all tests.
However, the result does not correspond to what I would expect. After running the unit tests up to L94, I see below category tree in the gui, where new nodes are attached under 'Assets'. However, the 'Assets' node was not part of our specification:
account_categories = {
'/Anlagevermögen/hello': 1000,
'/Anlagevermögen/world/how/are/you/?': 1010,
'/Anlagevermögen/feeling/kind/of/warm': 1020,
'/Anlagevermögen/are': 1020,
'/Anlagevermögen/you?': 1020,
'/Anlagevermögen/Finanzanlagen': 6000,
}
Pull Request: Update Category Handling in CashCtrlClient
Summary
This pull request introduces several updates and improvements to the
CashCtrlClient
class, particularly focusing on the handling of category updates. It includes new tests to validate these changes, ensuring robustness and correctness.Changes
New Test Cases
test_update_account_categories_with_list
ValueError
.test_update_file_categories_with_dict
ValueError
.test_account_category_update
Code Updates
Handling Parent ID for Account Categories
Updating Account Category Numbers
Target Type Validation
Update Categories Method Signature
Adding Number Column for Account Categories
Enforcing Data Types
Path Handling
Conclusion
@lasuk Please review the changes and provide feedback or approval for merging. There are not so many changes, so you can point to any part of code that you see we can improve