support dict and list items in API call data parameter

macxred / cashctrl_api

Python client for the CashCtrl REST API

MIT License

0 stars 0 forks source link

support dict and list items in API call data parameter #9

Closed chappi closed 4 months ago

chappi commented 4 months ago

fixes #4

lasuk commented 4 months ago

Thanks. Looks good. I've submitted a proposal for an alternative implementation as 17dc736. Please review my commit, shout if you do not like it or just push a new commit to adapt it to your taste.

Changes

Slightly simpler implementation of CashCtrlAPIClient()._request (without a sub-function).
Added a link to the discussion mentioned in #4 to explain why this code snippet is needed.

lasuk commented 4 months ago

@chappi: This PR is ready to merge from my side. The ball is on your side to comment on my changes.