search

macxred / cashctrl_ledger

Implementation of the abstract pyledger.LegderEngine interface with CashCtrl accounting service.
MIT License
0 stars 0 forks source link

Change Default for `delete` in `mirror_...` Methods #36

Closed lasuk closed 2 months ago

lasuk commented 5 months ago

Current State

CashCtrlLedger.mirror_... methods currently delete existing entries by default:

mirror_vat_codes(self, target_state: pd.DataFrame, delete: bool = True)
mirror_account_chart(self, target: pd.DataFrame, delete: bool = True)
mirror_ledger(self, target: pd.DataFrame, delete: bool = True)

Desired State

Do not delete entries by default. Users must explicitly specify if they want to erase existing entries.

Tasks

Main task:

  1. Change the default value of the delete parameter to False in the above methods.
  2. Update tests to reflect the new default behavior.

Side task:

  1. Rename the target_state argument in mirror_vat_codes to target for consistency across methods.