Feat/create get journal attachments function

macxred / cashctrl_ledger

Implementation of the abstract pyledger.LegderEngine interface with CashCtrl accounting service.

MIT License

0 stars 0 forks source link

Feat/create get journal attachments function #43

Closed AlexTheWizardL closed 3 months ago

AlexTheWizardL commented 3 months ago

In this pull request we created a function _get_ledger_attachments that find a real attachments that is linked to the ledger entry. CashCtrl doesn`t provide us with direct way to retrieve path of file that is linked to the ledger entry.

This function will come in hand for completing the cashctrl_ledger#7 issue.

@lasuk Please review the changes and provide feedback or approval for merging.

lasuk commented 3 months ago

Thanks.

Added a commit to enhance code readability. Pleas shout if you disagree.
Added a suggestion for a simpler test setup as a comment.

Back to you, @AlexTheWizardL.

AlexTheWizardL commented 3 months ago

This commit covers following changes:

add_ledger_entry() now returns an Id of created ledger entry. updated returning type and docstring
implemented the test logic that you described in the comment above

lasuk commented 3 months ago

Thanks.

Added one minor change.
Ready to merge.