Feat: create extended ledger

macxred / cashctrl_ledger

Implementation of the abstract pyledger.LegderEngine interface with CashCtrl accounting service.

MIT License

0 stars 0 forks source link

Closed AlexTheWizardL closed 3 weeks ago

AlexTheWizardL commented 2 months ago

The PR is best reviewed commit by commit.

d3e68af7ec5cf7415cd61a083b4ac5ffa199fe40 create CashCtrlLedgerExtended class
5cfdca38f74b0896a85b52b479b2c0615d7a6231 move "hackish" code and update test suits to use new class
5316d88f9214b9b1fc99ae6295a651bd67475660 update docstrings for CashCtrlLedger and CashCtrlLedgerExtended classes
d04b3ee5602959aa532662cc354fb37f115c1632 update readme with Core Components and Key Features sections

@lasuk Please review the changes and provide feedback or approval for merging.

codecov[bot] commented 1 month ago

Attention: Patch coverage is 94.69027% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cashctrl_ledger/extended_ledger.py	94.64%	6 Missing :warning:

Flag	Coverage Δ
unittests	`93.92% <94.69%> (-0.11%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cashctrl_ledger/__init__.py	`100.00% <100.00%> (ø)`
cashctrl_ledger/ledger.py	`92.68% <ø> (-0.62%)`	:arrow_down:
cashctrl_ledger/extended_ledger.py	`94.64% <94.64%> (ø)`

lasuk commented 3 weeks ago

I've pushed revised documentation and docstrings as e88b8e7. @AlexTheWizardL: Please souls if you disagree.

lasuk commented 3 weeks ago

From my point of view, the sole remaining question is the class name.