Closed AlexTheWizardL closed 3 weeks ago
Thanks for completing 'price' methods to the extend supported by the CashCtrl API.
I've added a commit to further clarify error messages and docstrings.
Ready for merging as soon as the CI test gives us the green light ..
All modified and coverable lines are covered by tests :white_check_mark:
Flag | Coverage Δ | |
---|---|---|
unittests | 93.24% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing lines | Coverage Δ | |
---|---|---|
cashctrl_ledger/ledger.py | 92.68% <100.00%> (+0.02%) |
:arrow_up: |
This PR covers adding of
price()
methodLimitations and details:
history
of price changes. The"currency/exchangerate"
endpoint is the only one to calculate theexchange rate
and it returnsonly one
float value at a timecurrency/create.json
endpoint and trying to receive its rate from the"currency/exchangerate"
endpoint it returns an empty string and doesn't see a new currency@lasuk Please review the changes and provide feedback or approval for merging.