Open AlexTheWizardL opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Flag | Coverage Δ | |
---|---|---|
unittests | 94.43% <100.00%> (+0.40%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
cashctrl_ledger/constants.py | 100.00% <100.00%> (ø) |
|
cashctrl_ledger/ledger.py | 93.77% <100.00%> (+0.47%) |
:arrow_up: |
Thanks, @AlexTheWizardL, for this PR, and for your flexibility in making it a priority!
I've added two commits. Please yell if you disagree:
The provided functionality already covers my use case. I have three suggestions for further improvement:
enforce_dtypes
to ensure the data frame has required columns of the right type. What do you think?
This PR covers creating the
FX_revaluation()
method that triggersCashCtrl
to automatically allocate foreign exchange gains or losses based on the provided exchange rates. This logic is covered with a test suit.@lasuk Please review the changes and provide feedback or approval for merging.