search

macxred / pyledger

Python package to streamline the implementation and management of accounting systems.
MIT License
0 stars 0 forks source link

Feat: modify base tests #33

Closed AlexTheWizardL closed 1 month ago

AlexTheWizardL commented 2 months ago

This PR focuses on modifying the base tests with the following objectives:

  1. Resolve Incoherence in Testing Data: Ensure consistency across the testing datasets, aligning them with the updated logic and expected outcomes.

  2. Update dump() and restore() Interface: Modify the interface for dump() and restore() to reflect new requirements or implementation changes, improving clarity and functionality.

  3. Define BaseTest Class: Introduce a BaseTest class that will store and manage a common set of data used across different test cases, promoting reusability and reducing redundancy in test setup.

  4. Update Error Handling in Tests: Revise tests that expect errors to include the error class and error message as arguments. This enhances test readability and ensures precise error handling in expected failure scenarios.

This PR is crucial for enhancing the clarity, maintainability, and accuracy of our Base Tests approach.

@lasuk Please review the changes and provide feedback or approval for merging.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
unittests 64.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyledger/ledger_engine.py 65.43% <100.00%> (ø)
lasuk commented 1 month ago

Thanks for addressing the review comments! Ready to merge ...